chore(logging): improved logs when using errors-only#8889
Closed
anthonyshew wants to merge 3 commits intomainfrom
Closed
chore(logging): improved logs when using errors-only#8889anthonyshew wants to merge 3 commits intomainfrom
anthonyshew wants to merge 3 commits intomainfrom
Conversation
ghost
added
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
🟢 Turbopack Benchmark CI successful 🟢Thanks |
Contributor
🟢 CI successful 🟢Thanks |
anthonyshew
force-pushed
the
shew-11809
branch
from
d596ed3 to
d58d83d
Compare
anthonyshew
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question: Will this create log groups in CI that previously didn't exist? Leaving as draft until I learn more on this (and if the team thinks this is a good change).
Description
Previously,
errors-onlywouldn't log anything on a successful task. Your tasks would be running, butturboappeared to be hanging. The task would only print the "leader log" that its running when it errors so you'd get no visual feedback that it even started.With a few more thoughtful logs, we can make it more clear that your tasks are currently running (though there aren't logs printing).
Considerations
This is a bit of a spiritual departure from truly being logging with strictly only errors but I'm of the opinion that the trade is worth it after reading #4042. I've also played with this in a few larger repos to find out how it feels and I'm finding it to be an improvement (though I'm open to feedback otherwise!)
Testing Instructions
👀
Screenshots
Note that these screenshots don't show the timing of the logs well. You'd previously only get the log that the task was happening after it already errored but now it shows when the task starts.
Mix of cache misses and hits
All successful hits
With cache disabled and failures
With cache disabled and successes
